Skip to content

🎨E2E: Adds missing prefix for websocket messages #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

🎨E2E: Adds missing prefix for websocket messages #8554

merged 1 commit into from
Oct 24, 2025
+45 −5

Conversation

@sanderegg
Copy link
Member

What do these changes do?

Osparc message are shown with: 📡OSPARC-WEBSOCKET:
S4l message are shown with: 📡S4L-WEBSOCKET:

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg requested a review from pcrespov as a code owner October 24, 2025 14:20
@sanderegg sanderegg self-assigned this Oct 24, 2025
@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Oct 24, 2025
@sanderegg sanderegg added this to the Imparable milestone Oct 24, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (1c61999) to head (30c7d2c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8554   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files        2011     2011           
  Lines       78605    78605           
  Branches     1349     1349           
=======================================
+ Hits        68785    68786    +1     
+ Misses       9416     9415    -1     
  Partials      404      404
Flag Coverage Δ
integrationtests 63.87% <ø> (-0.06%) ⬇️
unittests 86.23% <ø> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.61% <ø> (ø)
pkg_celery_library 83.22% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 92.87% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.96% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.94% <ø> (ø)
pkg_settings_library 90.29% <ø> (ø)
pkg_simcore_sdk 85.07% <ø> (+0.11%) ⬆️
agent 93.10% <ø> (ø)
api_server 91.62% <ø> (ø)
autoscaling 95.00% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.87% <ø> (-0.09%) ⬇️
dynamic_scheduler 96.66% <ø> (ø)
dynamic_sidecar 90.47% <ø> (+0.02%) ⬆️
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (ø)
storage 86.64% <ø> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.05% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c61999...30c7d2c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 347cf3f into ITISFoundation:master Oct 24, 2025
78 of 81 checks passed
@sanderegg sanderegg deleted the e2e/set-prefix-for-websockets branch October 24, 2025 14:29
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

🧪 CI Insights

Here's what we observed from your CI run for 30c7d2c.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@sanderegg sanderegg

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

1 participant

@sanderegg